feat: implement eth2util/signing helper#319
Closed
PoulavBhowmick03 wants to merge 1 commit intomainfrom
Closed
Conversation
iamquang95
reviewed
Apr 13, 2026
| } | ||
| } | ||
|
|
||
| async fn get_genesis(client: &EthBeaconNodeApiClient) -> Result<(Version, Root)> { |
Collaborator
There was a problem hiding this comment.
I think these functions should located in eth2api instead of signing
Collaborator
There was a problem hiding this comment.
With that, the signing here is closer to charon's signing. Also make the code can be reuse on other places.
Collaborator
|
@iamquang95 Could you take over this PR? |
Collaborator
|
Ok let me take this one |
Collaborator
|
Since the code change is quite diverged from this PR, I will close this and open a new one here: #340 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #168